fixed crash in case there is no weather data - #483
Merged
Conversation
| channel = content['query']['results']['weather']['rss']['channel'] | ||
| except: | ||
| # return empty Weather | ||
| return Weather(city=None, |
Member
There was a problem hiding this comment.
Let's just return None instead.
Member
|
Thanks for contributing. I left you some minor nits. I'll merge as soon as these have been fixed. |
This was referenced Apr 23, 2016
Merged
GeoBeBee
added a commit
to GeoBeBee/jasper-client
that referenced
this pull request
Apr 24, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weather plugin should not crash in case there can be no data retrieved (see #475)
Simply added some checks if there is any data received and added an error msg for the user in case of no data. Please note: thats not a fix for #475. Thats still open.
I also changed the testcase success criteria so that it does not fail in case that there is no data received. This might not be the intention and may need to be changed back.